==================== 1.0.0 ==================== ~~~~~~~~~~~~~~~~~~~~ TYPO3.Flow ~~~~~~~~~~~~~~~~~~~~ [TASK] Update version in Package.xml ----------------------------------------------------------------------------------------- * Commit: `f9f52ba `_ [TASK] Remove not-fixable functional test ----------------------------------------------------------------------------------------- Due to the changes to the session scope, this test is not working anymore and there is no easy way to test the expected behavior with the current code base. * Commit: `02bc4a8 `_ [BUGFIX] renderAnnotation handles boolean values correctly ----------------------------------------------------------------------------------------- When rendering annotations into proxy classes, boolean values for options got lost. * Fixes: `#31111 `_ * Commit: `1f17268 `_ [TASK] Make migrate-annotations.php a tiny bit less strict ----------------------------------------------------------------------------------------- When spaces (yuck) where used for indentation, @validate annotations were not migrated. This fixes that. Promise you will fix your indentation in return. * Commit: `d8af36d `_ [BUGFIX] Terminate cleanly after displaying exception message in CLI ----------------------------------------------------------------------------------------- If an exception occurred during a CLI request, it could happen that another exception was thrown and displayed (SignalSlot, ObjectManager not yet initialized) because the framework is in an early, unstable state and thus cannot shutdown the bootstrap normally. Therefore, if an exception was caught in the bootstrap, FLOW3 must exit directly without trying to shutdown the bootstrap in the regular way. * Commit: `3732564 `_ [BUGFIX] Fix package:import git URLs ----------------------------------------------------------------------------------------- * Fixes: `#31104 `_ * Commit: `e493de8 `_ [TASK] Disable SQL query logging by default ----------------------------------------------------------------------------------------- * Commit: `4fdeed8 `_ [TASK] Don't flush caches after package:create ----------------------------------------------------------------------------------------- Creating a new package does not really require flushing all caches because it only adds code (the package class) but does not remove any code. In Development context this should not cause any problems and developers save time if caches are not flushed. * Commit: `70f9da6 `_ [BUGFIX] Missing Lazy annotation in migration script ----------------------------------------------------------------------------------------- The Lazy annotation is missing in the migration-annotation.php script * Resolves: `#31083 `_ * Commit: `69f039e `_ [BUGFIX] Minor fix in LinkTest ----------------------------------------------------------------------------------------- This fixes a test for \TYPO3\Flow\Utility\Files::is_link() that failed to properly delete a previously generated symlink * Commit: `00f1cfe `_ [TASK] Remove scope annotations for prototypes ----------------------------------------------------------------------------------------- * Commit: `f1eca95 `_ [BUGFIX] Fix doc comment parsing of single line descriptions ----------------------------------------------------------------------------------------- A simple bugfix and test for single line description in doc comment blocks. * Commit: `629d5e3 `_ [TASK] Drop @author tags from source code ----------------------------------------------------------------------------------------- * Commit: `1da6a9e `_ [BUGFIX] Exception when entities/valueobjects are not prototype ----------------------------------------------------------------------------------------- * Fixes: `#31042 `_ * Commit: `9c48618 `_ [TASK] Beautify exception messages in command line interface ----------------------------------------------------------------------------------------- This wraps a try-catch block around the request handling part for command line commands and renders a more friendly exception message with a reference to the exception code and exception reference number, if any. * Commit: `2915d77 `_ [BUGFIX] make is_link() work around work for paths with trailing slash ----------------------------------------------------------------------------------------- On Windows \TYPO3\Flow\Utility\Files::is_link() compares the given path with the resolved absolute path due to a bug in the native is_link() implementation. This fails if the given path ends on a slash because that is stripped of by PHPs realpath() function. This change strips of any trailing slash before comparing the paths. * Resolves: `#31061 `_ * Commit: `b306b18 `_ [TASK] Clean up unit tests using the real ReflectionService ----------------------------------------------------------------------------------------- * Commit: `994f209 `_ [TASK] Cache annotation parsing results ----------------------------------------------------------------------------------------- Now class and property annotations are collected during regular class reflection and reused later. This avoids building a new class/property reflection and parsing of code and docblocks for every call reading annotations. * Related: `#27627 `_ * Commit: `3cc446e `_ [TASK] Fix edge case in annotation migration script ----------------------------------------------------------------------------------------- The script failed to replace (some?) nested ORM annotations with prefixed ones. * Related: `#27627 `_ * Commit: `b22b157 `_ [BUGFIX] Fix error when doctrine:validate finds errors ----------------------------------------------------------------------------------------- * Commit: `207a6c9 `_ [BUGFIX] PackageManager::createPackage() creates invalid annotation ----------------------------------------------------------------------------------------- The PackageManager::createPackage() that is called by the package:create command still creates a Package.php file with a "@scope" annotation. * Resolves: `#31052 `_ * Commit: `139a4da `_ [BUGFIX] Reuse FLOW3 classloader in ReflectionService ----------------------------------------------------------------------------------------- There was a second class loader being created for the annotation parser. It was lacking the available packages and thus failed under some circumstances. The changes adds reuse of the classloader already created in the FLOW3 bootstrap. * Fixes: `#31015 `_ * Related: `#27627 `_ * Commit: `59b7586 `_ [TASK] Add appendExceedingArguments setting to all default routes ----------------------------------------------------------------------------------------- This adds the setting appendExceedingArguments to the default fallback routes of FLOW3 in order to make more custom routes work out of the box. * Related: `#30778 `_ * Commit: `b483234 `_ [!!!][TASK] Only append exceeding request arguments to URI if configured ----------------------------------------------------------------------------------------- This changes the default behavior of the routing framework in order to be more consequent and easier to extend in the future. In detail this changes handling of arguments that are passed to the router::resolve() method but are not part of the route configuration. Until now these arguments were just appended to the resulting URI as query string, but this leads to unexpected behavior (see Now, if you need this behavior, you have to explicitly tell the route by enabling the setting "appendExceedingArguments". This is done for the default action route provided with FLOW3, so that most links will work out of the box. * Resolves: `#30778 `_ * Commit: `d74ce5d `_ [BUGFIX] Routing does not always work if splitString is optional ----------------------------------------------------------------------------------------- If the route part following an identity route part optional like "{post}(.html)", the identityRoutePart creates a correct link but matching of the URI without the optional part fails, if the dynamic part contains the split string (in this example if the post contains the string ".html"). This change fixes this by always matching against the complete routePath with an improved RegEx. * Resolves: `#30929 `_ * Commit: `ce14c00 `_ [TASK] Safeguard APC use (in CLI requests) ----------------------------------------------------------------------------------------- When activating APC as cache for Doctrine one would get fatal errors in CLI, because by default APC is disabled for CLI PHP. Thus we check for the existence of apc_fetch() before actually using the ApcCache. * Commit: `10fc76e `_ [TASK] Convenience Method for adding FlashMessages ----------------------------------------------------------------------------------------- This adds a method addFlashMessage() to the AbstractController This should be used for adding FlashMessages instead of interacting with the FlashMessageContainer directly in order to reduce interdependencies. Besides this change renames the default severity of FlashMessages from SEVERITY_MESSAGE to SEVERITY_OK. * Related: `#30825 `_ * Commit: `1f9a0e6 `_ [TASK] Teach AOP classAnnotatedWith & methodAnnotatedWith ----------------------------------------------------------------------------------------- Two new point cut designators added, includes tests. The pattern given is used as is, only backslashes are escaped for ease of use. Also changes the use of classTaggedWith and methodTaggedWith use in FLOW3 itself to the new designators. Related:# 27627 * Commit: `db6c825 `_ [TASK] Useless cleanup of @return annotations... ----------------------------------------------------------------------------------------- just because I touched those files anyway. * Commit: `4e01754 `_ [TASK] Adjust to new annotation syntax ----------------------------------------------------------------------------------------- The syntax for annotations changed with #27627, this adjusts the code as needed. * Related: `#27627 `_ * Commit: `42e8a5e `_ [TASK] Support new annotation syntax ----------------------------------------------------------------------------------------- This adds support for the new annotation syntax in a way that aims to change as little code as needed. It does this by adding support for namespaced annotations to DocCommentParser, adding some methods to read annotations using Doctrine Common to the ReflectionService and adjusts some other parts of the code that needed to be changed already. Existing annotations in userland code can be migrated using the migrate-annotations.php script. Run it without arguments to get instructions. Further changes to fully resolve #27627 will follow. * Related: `#27627 `_ * Commit: `f00f63f `_ [TASK] Add our annotations as classes ----------------------------------------------------------------------------------------- This adds classes for all annotations used in FLOW3 to the TYPO3\Flow\Annotations namespace. * Related: `#27627 `_ * Commit: `32bb751 `_ [TASK] Remove leftover encoding declarations ----------------------------------------------------------------------------------------- * Resolves: `#30861 `_ * Commit: `b7573cb `_ [!!!][BUGFIX] invalid YAML parser result should be empty array ----------------------------------------------------------------------------------------- A non array result of the symfony YAML parser will now be converted to an empty array to not break things. Breaking because the new parser seems to behave different than HordeYaml in some circumstances, so errors may arise due to missing configuration because the file wasn't parsed. * Commit: `795c7d0 `_ [BUGFIX] Fix access denied exception after session timeout with CSRF ----------------------------------------------------------------------------------------- This change nests the firewall inspection in the try catch block that also catches AuthenticationRequired exceptions from requests. The CsrfProtection pattern will check if any CSRF token is present in the context and throws an AuthenticationRequired exception otherwise to proceed to an entry point for re-authentication. * Resolves: `#30436 `_ * Commit: `0edbd68 `_ [FEATURE] Initialize session and session objects on demand ----------------------------------------------------------------------------------------- The default behavior of FLOW3 was that a session was initialized – and thus a cookie sent – on every request, no matter if the session was needed or not. This feature delays session initialization until when a session is really needed. Existing sessions will be resumed automatically. A new session is only started if the Session->start() method is called explicitly, or if a method which was tagged with @session autostart=true was called. * Resolves: `#26358 `_ * Commit: `6d7d3b9 `_ [TASK] Get rid of some duplicate code ----------------------------------------------------------------------------------------- Moves one duplicate method up and removes one that was completely unused by now. The tests for the latter have been moved to where the code is actually still used. * Commit: `c03a6ab `_ [!!!][TASK] Change default authentication strategy ----------------------------------------------------------------------------------------- This changes the default authentication strategy from "anyToken" to "atLeastOneToken" in order to provoke an exception if authentication fails in the common use case (login with username and password). * Resolves: `#29488 `_ * Commit: `d77d259 `_ [TASK] Remove scope annotations from interfaces ----------------------------------------------------------------------------------------- They have no effect and in userland code even trigger an error. * Commit: `b7326a8 `_ [TASK] Make PHPSessions configurable ----------------------------------------------------------------------------------------- Resolve: #30848 * Commit: `0800ec1 `_ [!!!][TASK] Clean up Flash Messages API ----------------------------------------------------------------------------------------- - FlashMessageContainer is moved to \TYPO3\Flow\MVC - FlashMessage is removed - FlashMessageContainer now uses \TYPO3\Flow\Error\Message instead of FlashMessage objects - Message has an optional argument "title", which is not used so far but that way is compatible to v4 flashMessages - Message has now a "severity" property * Resolves: `#30825 `_ * Commit: `2dc4ac4 `_ [BUGFIX] Proxy Class Builder should work with NULL default ----------------------------------------------------------------------------------------- Optional arguments with NULL default value will now be correctly autowired in the proxy class. Therefor optional arguments after a default NULL will be correctly handled. * Resolves: `#30858 `_ * Commit: `8175869 `_ [BUGFIX] Security_Randomizer fallback does not work ----------------------------------------------------------------------------------------- This fix should allow Security_Randomizer to work on Win x64 by making sure that the mt_rand fallback actually returns random bytes. see http://sourceforge.net/tracker/?group_id=294448&atid=1243705 for more details * Resolves: `#29976 `_ * Commit: `1dd7ba6 `_ [TASK] Use Symphony YAML parser for settings instead Horde/YAML ----------------------------------------------------------------------------------------- Drop Horde YAML parser and use Symfony YAML parser instead. It is now included in the new package Symfony.Component.Yaml be sure to have in active to test this. Also drop Symfony Console Component * Resolves: `#30826 `_ * Commit: `23468ad `_ [BUGFIX] No endless recursion on a missing CLI PHP binary ----------------------------------------------------------------------------------------- If a wrong path has been specified or a PHP binary is used which does not support CLI, FLOW3 could end up in an endless recursion on executing the compile sub command. This change set adds a check for the proper SAPI type in FLOW3's command line script. * Fixes: `#30633 `_ * Commit: `a7da340 `_ [TASK] ClassLoader returns TRUE now if class was found ----------------------------------------------------------------------------------------- * Commit: `bd7ea42 `_ [TASK] Fix type annotation for ReflectionService in ObjectSerializer ----------------------------------------------------------------------------------------- The var annotation for the ReflectionService property was wrong. * Commit: `7e90134 `_ [TASK] Fixed consistent typo in variable name ----------------------------------------------------------------------------------------- In the bootstrap one variable was called $possibleComanndControllerIdentifier instead of $possibleCommandControllerIdentifier * Commit: `d8bed4b `_ [BUGFIX] Static Route Parts are not reset ----------------------------------------------------------------------------------------- StaticRoutePart::resolve() sets the value to the route parts name (= the corresponding URI part). RoutePart::match() merges the route parts value into the resulting request arguments. The value of the route part must be reset to NULL before the route parth is processed. The StaticRoutePart currently fails to do so. Usually this has no effect because match() is always called before resolve() but it fails when using FLOW3 with an app server like AiP. * Resolves: `#30542 `_ * Commit: `9d03bb5 `_ [TASK] Use IndexedReader instead of our own "fix" ----------------------------------------------------------------------------------------- There was a mapAnnotationsToKeys() method in our annotation driver. Using the IndexedReader from Doctrine is the better option. * Commit: `6216c3d `_ [TASK] Another cosmetic fix. ----------------------------------------------------------------------------------------- * Commit: `b46db7b `_ [TASK] Trivial cosmetic fixes. ----------------------------------------------------------------------------------------- * Commit: `cb9d87a `_ [BUGFIX] Wrong default value 'Text' for $dataType ----------------------------------------------------------------------------------------- The default value 'Text' for $dataType in the signature of the method addNewArgument should be 'string' because there is no TypeConverter for 'Text'. * Resolves: `#29978 `_ * Commit: `2b29376 `_ [BUGFIX] Fix regression: flush caches blocked by aggregate analysis ----------------------------------------------------------------------------------------- On trying to flush the caches after a package has been removed or deactivated, the Reflection Service can fail due to stale class schema cache entries. Like the other similar code, the code introduced in I5538230b42624629a6746ebff5e9e5dae6e93859 must also check if the class still exists. * Relates: `#29416 `_ * Commit: `bdb224d `_ [TASK] Clarify persistence behavior for inheritance in aggregate roots ----------------------------------------------------------------------------------------- This adds a number of functional tests to make sure the repository behaves as expected. For Person and User, the latter being a subclass of the former, a PersonRepository will also be able to handle User: * it will return both types * it will accept both types for add/remove/update * Resolves: `#29543 `_ * Commit: `095a742 `_ [!!!][BUGFIX] Make sure only complete hierarchies are aggregate root ----------------------------------------------------------------------------------------- Reported as "Aggregate root detection for Person vs AbstractParty is broken" the issue at hand was that one could not rely on certain semantics bound to aggregate root handling: The association from Account to Person is cascaded during persist, because the fact that Person has a PersonRepository is not detected from the type hint to AbstractParty in the Account class. The solution this change introduces is as follows: all classes in a hierarchy must have a repository assigned. This can be done by having one repository on the tip of the hierarchy, but any entity can have it's own repository as well. * Fixes: `#29416 `_ * Commit: `23961c8 `_ [TASK] Clean up class schema building code ----------------------------------------------------------------------------------------- Extract some code into methods to make coming changed easier. Also add another test to the unit test for ClassSchema. * Commit: `c2cf3aa `_ [TASK] Some tiny spelling fixes ----------------------------------------------------------------------------------------- * Commit: `5704577 `_ [BUGFIX] Allow file exists check through ResourceStreamWrapper ----------------------------------------------------------------------------------------- For file exists checks, we need to make sure that the ResourceStreamWrapper returns FALSE when checking the path for a non-existing persistent resource, and does not continue to the package check. * Related: `#30254 `_ * Commit: `0ef0e45 `_ [!!!][BUGFIX] Fix column names for association properties ----------------------------------------------------------------------------------------- For associations without a join table the column names in the model tables followed the target type, not the property name as it was intended (flow3_resource_resourcepointer instead of resourcepointer). This is a breaking change, as it requires database changes. For the framework packages migrations are included, for custom code generating a migration (or using update) is needed. * Fixes: `#30223 `_ * Commit: `395997d `_ [TASK] Simplify license header in PHP files ----------------------------------------------------------------------------------------- * Resolves: `#29415 `_ * Commit: `1a7fd59 `_ [TASK] Fix foreign key handling in migration ----------------------------------------------------------------------------------------- Migrating down would not work because FK constraints where not named. * Commit: `3831728 `_ [TASK] Fix failing unit test after SecurityContext change ----------------------------------------------------------------------------------------- Fix a failing unit test after change 5358. * Commit: `35bda30 `_ [BUGFIX] AOP proxies are no longer broken if __call() exists ----------------------------------------------------------------------------------------- If a class contains a magic __call() method, AOP proxy classes are broken due to a is_callable() use – method_exists() in addition would be correct. * Fixes: `#30351 `_ * Commit: `3e36de8 `_ [BUGFIX] @version annotations are not ignored anymore ----------------------------------------------------------------------------------------- For optimization reasons FLOW3's Reflection Service ignored @version annotations. Due to this, Doctrine's Optimistic Locking feature could not be used. This change set removes @version from the list of ignored tags. * Fixes: `#30380 `_ * Commit: `9c85705 `_ [BUGFIX] No persistence side effects anymore in functional tests ----------------------------------------------------------------------------------------- Doctrine's Unit of Work still contained objects from previous tests. In order to prevent side effects, the Entity Manager must be cleared before executing further tests. * Fixes: `#30379 `_ * Commit: `10af83a `_ [FEATURE] Support mapping of integer to string ----------------------------------------------------------------------------------------- Just a small additional source type in the StringConverter. * Resolves: `#30317 `_ * Commit: `892d67d `_ [TASK] Guard the account for NULL when getting a party ----------------------------------------------------------------------------------------- This could happen, if the account in the persistence was deleted during a session. * Commit: `2ae3f0c `_ [BUGFIX] CLI Help throws exception if related comments are not available ----------------------------------------------------------------------------------------- The flow3:help:help command parses @see annotations of the commands and retrieves the method description of related commands. This leads to an exception if the target command is not available (e.g. if the respective package is not loaded). This change fixes this by replacing the short description with "Command not available" in those cases. * Resolves: `#30261 `_ * Commit: `75a8b89 `_ [BUGFIX] CLI CommandManager throws exception for ambiguous commands ----------------------------------------------------------------------------------------- This change ensures that the CommandManager returns the complete CommandIdentifier for commands with the same controller and command names, for example: package.key:controller:command and otherpackage.key:controller:command * Resolves: `#30260 `_ * Commit: `5e5daa1 `_ [TASK] Clean up PersistentObjectConverter unit test ----------------------------------------------------------------------------------------- * Commit: `87863f3 `_ [BUGFIX] Read ObjectConverter configuration correctly ----------------------------------------------------------------------------------------- When checking for property mapping configuration the ObjectConverter asks for the "ArrayToObjectConverter" configuration. This is a leftover and should be "ObjectConverter". Also remove the unused persistence manager that is injected. * Fixes: `#30262 `_ * Commit: `a9d8cc9 `_ [BUGFIX] Allow ObjectConverter to use constructor parameters ----------------------------------------------------------------------------------------- We need this for image upload in Phoenix. * Resolves: `#30255 `_ * Commit: `d366973 `_ [BUGFIX] Allow file creation through ResourceStreamWrapper ----------------------------------------------------------------------------------------- For file creation, we need to make sure that the ResourceStreamWrapper also returns the path for a non-existing persistent resource. We need that e.g. for TYPO3 image uploads to work. * Resolves: `#30254 `_ * Commit: `c031922 `_ [BUGFIX] Do not override parent instance in compiled proxies ----------------------------------------------------------------------------------------- * Resolves: `#30234 `_ * Commit: `0275a5f `_ [!!!][TASK] Create lower cased URIs by default ----------------------------------------------------------------------------------------- The routing framework is capable of creating case sensitive URIs so it is possible to resolve different actions depending on the case of URI segments. This changes the behavior to convert URIs to lower case by default as that is the most common requirement. If you want to keep the case, you can achieve that by setting toLowerCase to FALSE. This can be done for the whole route or for specific Route Parts: .. code-block:: yaml - name: 'Case sensitive Route' uriPattern: 'posts/{post}/{category}' defaults: '@package': 'TYPO3.Blog' '@controller': 'Post' '@action': 'index' '@format': 'html' toLowerCase: false - name: 'Case sensitive Route Part' uriPattern: 'posts/{post}/{category}' defaults: '@package': 'TYPO3.Blog' '@controller': 'Post' '@action': 'index' '@format': 'html' routeParts: post: toLowerCase: false Note: This is a breaking change in the sense that dynamic route parts are now resolved to a lower cased string by default. * Resolves: `#29977 `_ * Commit: `755a735 `_ [BUGFIX] Fix recursion error in \TYPO3\Flow\var_dump() ----------------------------------------------------------------------------------------- A var_dump of for example the PersistenceManager results in a memory error. This happens because the dumped object is not checked against the blacklisted class list. * Resolves: `#30163 `_ * Commit: `01ffa9c `_ [TASK] Fix unit test side effects ----------------------------------------------------------------------------------------- The CacheFactoryTest created directories in the distribution root when run from there. Now it used a mocked filesystem. The warnings about chmod() seem to be unavoidable, some comments about that were added to the affected test. * Commit: `b301de5 `_ [FEATURE] Add generic Identity RoutePartHandler ----------------------------------------------------------------------------------------- This implements improved routing for persisted objects. When an object type is specified in the routing configuration, the new "IdentityRoutePart" is used to match/resolve the route part. By default the resolved URI representation (path segment) is built from the identity properties of the domain model. If no identity properties are defined, the technical identifier (UUID) is used. Additionally a custom URI pattern can be defined in the route. For properties of type DateTime the date format can be specified prefixed by a colon. If a path segment already exists, the IdentityRoutePart handler will append an increasing counter to ensure unique URIs. Sample Route: .. code-block:: yaml - uriPattern: 'posts/{post}' defaults: '@package': 'TYPO3.Blog' '@controller': 'Post' '@action': 'show' '@format': 'html' routeParts: post: objectType: TYPO3\Blog\Domain\Model\Post * Resolves: `#8736 `_ * Commit: `38232ef `_ [BUGFIX] Don't remove referenced entities ----------------------------------------------------------------------------------------- This change adds a check to the removal of dereferenced entities in the AbstractBackend. If the entity was visited during the peristence, another reference to the entity was found and it will not be removed. * Commit: `2c949e3 `_ [!!!][FEATURE] Improve default routing for entities ----------------------------------------------------------------------------------------- This improves the default dynamic route part handler so that it can resolve objects that are known to the persistence manager. If the routing comes across an object when creating an URI, the identifier (UUID) of the object is used to resolve the URI part. This is a breaking change, because routes with dynamic parts now also match objects even if no custom route part handler is used. The route: .. code-block:: yaml - uriPattern: 'posts/{post}' defaults: '@package': 'TYPO3.Blog' '@controller': 'Post' '@action': 'show' '@format': 'html' Will now result in the URI "posts/" * Related: `#8736 `_ * Commit: `0863e52 `_ [TASK] Reanimate some ActionController unit tests ----------------------------------------------------------------------------------------- * Commit: `cc2caa5 `_ [BUGFIX] Fix check against @ignorevalidation annotations ----------------------------------------------------------------------------------------- The check for argument names against @ignorevalidation annotations was done with the raw argument name, but the annotation is to be given with a leading dollar sign:: @ignorevalidation $fooBar The check thus always failed. * Fixes: `#29761 `_ * Commit: `87418d9 `_ [BUGFIX] Fix case of sub package key arguments in Router::getControllerObjectName() ----------------------------------------------------------------------------------------- This just changes the method argument name to be in sync with the annotation * Commit: `72269db `_ [FEATURE] Provide signal for after objects have been persisted ----------------------------------------------------------------------------------------- This provides two signals – one for the generic and one for the Doctrine persistence manager - which is emitted right after persistAll() was called. * Commit: `b28cd35 `_ [BUGFIX] Proxy code of advised abstract classes don't produce errors ----------------------------------------------------------------------------------------- The AOP ProxyClassBuilder produced invalid code when signals were defined in an abstract class. This was due to invalid proxy class code and a wrong initialization procedure. This change fixes the issue by making sure that the advice information is also built for parent proxy classes when sub classes are used. Additionally this change set contains functional tests for the AOP proxy and the signal slot mechanism. * Fixes: `#28638 `_ * Commit: `43f08cb `_ [BUGFIX] Lifecycle annotations were not detected ----------------------------------------------------------------------------------------- The detection of Doctrine lifecycle event annotations was broken since the last Doctrine update (because of the changed return values of the annotation reader). * Fixes: `#29908 `_ * Commit: `31a9345 `_ [BUGFIX] (Resource): Resource manager can also handle files without extension ----------------------------------------------------------------------------------------- Furthermore, we use move_uploaded_file instead of rename to move the target file to the final destination, as this also works across partition boundaries in all cases. * Related: `#29572 `_ * Commit: `c6546f4 `_ [TASK] Use correct respone mock in FunctionalTestCase ----------------------------------------------------------------------------------------- The sendWebRequest() method used mocked ResponseInterface, but lacks the setStatus() method present in the Web\Response class. This change makes it use a mock of Web\Response. * Commit: `1c27b88 `_ [FEATURE] Support dropping instances in the Object Manager ----------------------------------------------------------------------------------------- This adds a non-API function to the Object Manager which allows for unregistering instances of arbitrary objects. The next time an object of that type is requested, a new instance will be created. This function can be used in functional tests, but must be used with care because if other parts of the application already use an instance of the respective type, the whole application might become unstable because multiple instances of a singleton could be the result. * Resolves: `#30018 `_ * Commit: `d22fa5e `_ [BUGFIX] Less persistence side effects in functional tests ----------------------------------------------------------------------------------------- Previously, the persistence manager was only teared down after a whole test case ran through. This change makes sure that this clean up happens after each individual test to ensure that data generated by previous tests are gone when the next test is run. * Fixes: `#30017 `_ * Commit: `eca27e4 `_ [BUGFIX] Invalid static resource symlinks are removed again ----------------------------------------------------------------------------------------- Whenever the resource publishing of FLOW3 finds an invalid symbolic link in the static resources directory, it should remove that link and re-publish the resources of the package in question. Because Utility\Files::removeDirectoryRecursively() could not cope with symbolic links, this auto-cleanup failed. This change set makes removeDirectoryRecursively() and emptyDirectoryRecursively() symlink aware and sets its behavior to not follow links but remove the links instead. Note: change set I2d5c544e6db728594209294cfe779b8bad3c6d59 did not completely fix the issue. If the old symbolic link pointed to nowhere, the publishStaticResources() method failed. * Fixes: `#29777 `_ * Commit: `5adfc6f `_ [BUGFIX] (Property): Enable mapping of Value Objects ----------------------------------------------------------------------------------------- If a value object is edited through a Fluid form, we should not try to fetch it from persistence, but need to re-create it from scratch due do the value object semantics. Thus, we need to discard the __identity property in that case. The change set also adds a functional test. * Resolves: `#29905 `_ * Commit: `ba7f2df `_ [BUGFIX] Fix help command controller argument use ----------------------------------------------------------------------------------------- The command controller was intended to be used with the optional command identifier without using that as a named option - but that is a requirement. Thus we now use the first exceeding argument if the option is not given. * Fixes: `#29895 `_ * Commit: `320877b `_ [!!!][BUGFIX] Optional CLI arguments have to be named ----------------------------------------------------------------------------------------- This reverts commit 090c243226aee1ede12ab289d651bdbb80564f92 and brings back Ia9f59326e5c4dc793102db20883ae798ae2f27cd which was correct after all. * Commit: `2908881 `_ Revert "[!!!][BUGFIX] Optional CLI arguments have to be named" ----------------------------------------------------------------------------------------- This reverts commit a43360b35c0b44288d204462b825dfa564bd3cf2 * Commit: `090c243 `_ [!!!][BUGFIX] Optional CLI arguments have to be named ----------------------------------------------------------------------------------------- Currently exceeding arguments are ignored if a command has optional arguments, because the RequestBuilder then can't differentiate them. This change requires options to be named: For commands expecting one optional argument you were able to write ./flow3 command value Now you'd have to write ./flow3 command --optional-argument value * Resolves: `#29792 `_ * Commit: `a43360b `_ [BUGFIX] Invalid static resource symlinks are removed again ----------------------------------------------------------------------------------------- Whenever the resource publishing of FLOW3 finds an invalid symbolic link in the static resources directory, it should remove that link and re-publish the resources of the package in question. Because Utility\Files::removeDirectoryRecursively() could not cope with symbolic links, this auto-cleanup failed. This change set makes removeDirectoryRecursively() and emptyDirectoryRecursively() symlink aware and sets its behavior to not follow links but remove the links instead. * Fixes: `#29777 `_ * Commit: `af9ac03 `_ [BUGFIX] Repository does not crash with wrong argument type ----------------------------------------------------------------------------------------- This fixes the safe guard in the add(), remove() and update() functions of the base repository. * Commit: `3a9a2b1 `_ [TASK] Remove @license annotation from files ----------------------------------------------------------------------------------------- * Related: `#29415 `_ * Commit: `410f746 `_ [TASK] Fix a method docblock in RawValidator ----------------------------------------------------------------------------------------- * Commit: `d5f5e44 `_ ~~~~~~~~~~~~~~~~~~~~ TYPO3.Fluid ~~~~~~~~~~~~~~~~~~~~ [TASK] Update version in Package.xml ----------------------------------------------------------------------------------------- * Commit: `58f143c `_ [BUGFIX] AjaxWidgetContext is not stored in session ----------------------------------------------------------------------------------------- This change adds the required Session autostart annotation to the AjaxWidgetContext. * Resolves: `#31119 `_ * Commit: `4b48063 `_ [TASK] Remove scope annotations for prototypes ----------------------------------------------------------------------------------------- * Commit: `caafde6 `_ [TASK] Drop @author tags from source code ----------------------------------------------------------------------------------------- * Commit: `9c2e837 `_ [TASK] Fix two failing unit tests ----------------------------------------------------------------------------------------- * Related: `#31015 `_ * Commit: `cf7b9db `_ [TASK] Fix two failing unit tests ----------------------------------------------------------------------------------------- Two tests started to fail because the annotation reader was not initialized. Bad functional style unit tests fixed the dirty way... * Related: `#27627 `_ * Commit: `8894121 `_ [TASK] Adjust to new annotation syntax ----------------------------------------------------------------------------------------- The syntax for annotations changed with #27627, this adjusts the code as needed. * Related: `#27627 `_ * Commit: `984cc21 `_ [FEATURE] Catch Routing Exceptions in uri and link ViewHelpers ----------------------------------------------------------------------------------------- This change makes sure that exceptions that are thrown by the router are caught and rethrown as ViewHelper exceptions in all ViewHelpers that make use of the UriBuilder. This makes it easier for developers to debug their templates (see #30777). * Resolves: `#30777 `_ * Commit: `24a8e23 `_ [TASK] Remove scope annotations from interfaces ----------------------------------------------------------------------------------------- They have no effect and in userland code even trigger an error. * Commit: `77b5d77 `_ [TASK] Cleaned up Flash Messages API ----------------------------------------------------------------------------------------- Adjust to Flash Message cleanup in TYPO3.Flow. * Commit: `11ddba9 `_ [TASK] Fix case of a @see annotation ----------------------------------------------------------------------------------------- The annotation used @See (uppercase s), but @see is correct. * Commit: `10e0d07 `_ [TASK] Simplify license header in PHP files ----------------------------------------------------------------------------------------- * Resolves: `#29415 `_ * Commit: `14bacba `_ ~~~~~~~~~~~~~~~~~~~~ TYPO3.Kickstart ~~~~~~~~~~~~~~~~~~~~ [TASK] Update version in Package.xml ----------------------------------------------------------------------------------------- * Commit: `ce241a6 `_ [BUGFIX] Generating ActionControllers using a comma separated list creates wrong Models and Repositories --------------------------------------------------------------------------------------------------------- * Fixes: `#30980 `_ * Commit: `3a630b8 `_ [BUGFIX] Make Kickstarter use addFlashMessage() in CRUD controller ----------------------------------------------------------------------------------------- This uses addFlashMessage() instead of flashMessageContainer->add() in generated CRUD controllers. * Fixes: `#31082 `_ * Commit: `0d3d4b0 `_ [TASK] Use new keyword instead of create() ----------------------------------------------------------------------------------------- * Commit: `87c89da `_ [TASK] Remove scope annotations for prototypes ----------------------------------------------------------------------------------------- * Commit: `5a53a2e `_ [TASK] Drop @author tags from source code ----------------------------------------------------------------------------------------- * Commit: `12f7ae9 `_ [TASK] Adjust to new annotation syntax ----------------------------------------------------------------------------------------- The syntax for annotations changed with #27627, this adjusts the code as needed. * Related: `#27627 `_ * Commit: `542653d `_ [BUGFIX] DateTime properties throw exception ----------------------------------------------------------------------------------------- When kickstarting models that contain properties of type DateTime, CRUD Views throw exceptions because the property can't be converted to string implicitly. This is fixed by wrapping DateTime properties in format.date ViewHelpers in the affected templates. * Resolves: `#30526 `_ * Commit: `ca4761b `_ [FEATURE] Generate fields in views if Model already exists ----------------------------------------------------------------------------------------- When generating views add reflection of model-class to generate fields for existing properties in views * Resolves: `#30253 `_ * Commit: `afad63b `_ [TASK] Simplify license header in PHP files ----------------------------------------------------------------------------------------- * Resolves: `#29415 `_ * Commit: `895ac16 `_ [BUGFIX] Render @return annotation in CRUD actions ----------------------------------------------------------------------------------------- Generated CRUD actions did not have a @return annotation at all. * Fixes: `#30052 `_ * Commit: `db3fb3b `_ [TASK] Tweak help for kickstart:actioncontroller ----------------------------------------------------------------------------------------- * Commit: `9f6d1a3 `_ [FEATURE] Display update schema reminder ----------------------------------------------------------------------------------------- After kickstarting a new action controller with --generate-related or a new model, the command now displays a hint that the database schema needs to be updated manually. Also adjusts the KickstartCommandController to use outputLine() instead of echo and return. * Resolves: `#29883 `_ * Commit: `033cb94 `_ ~~~~~~~~~~~~~~~~~~~~ TYPO3.Party ~~~~~~~~~~~~~~~~~~~~ [TASK] Update version in Package.xml ----------------------------------------------------------------------------------------- * Commit: `7792f9c `_ [TASK] Remove scope annotations for prototypes ----------------------------------------------------------------------------------------- * Commit: `0bf7e4e `_ [TASK] Drop @author tags from source code ----------------------------------------------------------------------------------------- * Commit: `fd10606 `_ [TASK] Adjust to new annotation syntax ----------------------------------------------------------------------------------------- The syntax for annotations changed with #27627, this adjusts the code as needed. * Related: `#27627 `_ * Commit: `a541ef3 `_ [TASK] Use Collection interface, not ArrayCollection ----------------------------------------------------------------------------------------- * Commit: `9ecaa42 `_ fix case of @column annotation ----------------------------------------------------------------------------------------- * Commit: `904d203 `_ [!!!][TASK] Make PersonRepository a generic PartyRepository ----------------------------------------------------------------------------------------- The change to fix #29416 requires any AbstractParty to have a repository, not only subclasses like Person. If you were using PersonRepository, use PartyRepository instead now. * Related: `#29416 `_ * Commit: `a074d69 `_ [TASK] Simplify license header in PHP files ----------------------------------------------------------------------------------------- * Resolves: `#29415 `_ * Commit: `acaf644 `_ [TASK] Fix foreign key handling in migration ----------------------------------------------------------------------------------------- Migrating down would not work because FK constraints where not named. * Commit: `718546f `_ [BUGFIX] Adjust association property column names ----------------------------------------------------------------------------------------- The needed migration to go with the fix for #30223 (see change Ia32cfcc6cd49385a61845243e67cb0ddd62f5268). * Related: `#30223 `_ * Commit: `b275c75 `_ ~~~~~~~~~~~~~~~~~~~~ TYPO3.Welcome ~~~~~~~~~~~~~~~~~~~~ [TASK] Update version in Package.xml ----------------------------------------------------------------------------------------- * Commit: `daf32c8 `_ [TASK] Drop @author tags from source code ----------------------------------------------------------------------------------------- * Commit: `f246ff5 `_ [TASK] Adjust to new annotation syntax ----------------------------------------------------------------------------------------- The syntax for annotations changed with #27627, this adjusts the code as needed. * Related: `#27627 `_ * Commit: `f988bea `_ [TASK] Tiny fix to reload JS call in template ----------------------------------------------------------------------------------------- * Commit: `3fdc799 `_ [TASK] Simplify license header in PHP files ----------------------------------------------------------------------------------------- * Related: `#29415 `_ * Commit: `33b40a7 `_ ~~~~~~~~~~~~~~~~~~~~ Doctrine ~~~~~~~~~~~~~~~~~~~~ [TASK] Update version in Package.xml ----------------------------------------------------------------------------------------- * Commit: `2e9cad2 `_ [TASK] Update ORM to 2.2.0-DEV ----------------------------------------------------------------------------------------- Still includes 4 of our own patches on top of upstream commit 509e5fb12ff0ab7fc933338bd999c9c850297243. * Commit: `0054a16 `_ [TASK] Update Common to 2.2.0-DEV ----------------------------------------------------------------------------------------- * Commit: `2ab0454 `_ [TASK] Update ORM to 2.1.x ----------------------------------------------------------------------------------------- Still includes 5 of our own patches on top of upstream commit 623ab9cee97b99188f0b5bb671ef8e2618485bf5. * Commit: `8c09ee2 `_ [TASK] Update data fixtures plugin ----------------------------------------------------------------------------------------- It is now at 76f8221609129651937f52553f3e1b2bd915fd3e. * Commit: `e836b0e `_ [TASK] Update Migrations to master ----------------------------------------------------------------------------------------- * Commit: `ce1497e `_ [TASK] Update DBAL to 2.1.4-DEV ----------------------------------------------------------------------------------------- Still includes two of our own patches on top of upstream commit 17005ec6a0d1c6647597c37749a1087807e12c83 * Commit: `5079217 `_ [TASK] Update Common to 2.1.2 release ----------------------------------------------------------------------------------------- * Commit: `e4ed890 `_